refactor: Made react native dependencies optional #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@react-native-community/async-storage @react-native-community/netinfo
zashraf1985
changed the title
zashraf1985
added a commit
that referenced
this pull request
Jan 31, 2022
This reverts commit 116ee4b.
zashraf1985
added a commit
that referenced
this pull request
Jan 31, 2022
…and 0.9.4 for `js-sdk-event-processor` (#739) ## Summary React native dependencies were converted from `peer` to `optional` in `js-sd-datafile-manager` version `0.9.2` and `js-sdk-event-processor` version `0.9.3`. After releasing, it appeared that they did not work as expected. This PR reverts back that change which was made in #735 and updates changelog and npm version to make new releases for both the packages. ## Test plan - Manually tested. - All unit tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Made the following dependencies optional in
datafile-managerandevent-processorpackages.@react-native-community/async-storage@react-native-community/netinfoTest Plan