Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
166a490
uuid and murmurhash version updated to latest
f3sherry May 26, 2022
418be33
build fix
f3sherry May 26, 2022
25bfd9a
changed 'murmurhash' version to 1.0.0
f3sherry Jun 2, 2022
0061b1d
handled multiple error in test case for null bucketing in bucketer
f3sherry Jun 2, 2022
c03c0e0
wip
f3sherry Jun 6, 2022
96ba3b5
yml updated to 12+ versions
f3sherry Jun 6, 2022
34dc234
yml updated to 12 - 16 versions
f3sherry Jun 6, 2022
5a6a3c1
ci-test node version set to 14
f3sherry Jun 6, 2022
d4e7567
test only 12,14
f3sherry Jun 6, 2022
55c9689
v12
f3sherry Jun 6, 2022
beb8579
cross browser version revert to 8
f3sherry Jun 6, 2022
944e9da
testing
f3sherry Jun 6, 2022
f70b301
testing
f3sherry Jun 6, 2022
59b3541
2.0.1 murmurhash testing
f3sherry Jun 6, 2022
dee3757
safari version changed - testing
f3sherry Jun 6, 2022
e21fa34
testing
f3sherry Jun 6, 2022
9f32238
testing
f3sherry Jun 6, 2022
5469eff
reverted all browsers settings to default
f3sherry Jun 6, 2022
621bfde
bs_safari version testing
f3sherry Jun 6, 2022
4aecab2
testing
f3sherry Jun 6, 2022
454aff1
reverted back
f3sherry Jun 6, 2022
cb56969
v16 added to yml
f3sherry Jun 6, 2022
e09a338
v18 added
f3sherry Jun 6, 2022
1b4c557
browsers testing
f3sherry Jun 7, 2022
0783198
testing
f3sherry Jun 7, 2022
0a014a6
testing chrome
f3sherry Jun 7, 2022
6aead4f
edge added in browser's list
f3sherry Jun 7, 2022
71931e4
firefox testing
f3sherry Jun 7, 2022
b3ee1cc
testing
f3sherry Jun 7, 2022
0fb3bba
updated
f3sherry Jun 7, 2022
2c68277
testing
f3sherry Jun 7, 2022
9520730
testing
f3sherry Jun 7, 2022
0275feb
safari added
f3sherry Jun 7, 2022
9a56287
testing ie
f3sherry Jun 7, 2022
a1ee83a
ie testing
f3sherry Jun 7, 2022
489f1e9
file finalized
f3sherry Jun 7, 2022
ae5a30b
remove commented code
f3sherry Jun 7, 2022
efcbe6f
node version changed
f3sherry Jun 7, 2022
95a569e
copyright year updated
f3sherry Jun 9, 2022
ae6e20e
updated
f3sherry Jun 9, 2022
169ee2a
added particular test-app branch for testing
f3sherry Jul 4, 2022
0a1c2b9
pkg-lock
f3sherry Jul 4, 2022
6769922
test
f3sherry Jul 4, 2022
4b74ac2
revert yml changes
f3sherry Jul 5, 2022
c429dcd
revert yml changes
f3sherry Jul 5, 2022
0715872
testing browsers
f3sherry Jul 6, 2022
d2cd31f
testing browser
f3sherry Jul 6, 2022
2d963eb
chrome browser testing
f3sherry Jul 6, 2022
1806479
edge testing
f3sherry Jul 6, 2022
17bc91b
edge testing
f3sherry Jul 6, 2022
3d1ca7a
opera testing
f3sherry Jul 6, 2022
9181d01
testing opera
f3sherry Jul 6, 2022
02776c5
removed extra lines
f3sherry Jul 6, 2022
545a8cb
adjusted some browser versions
zashraf1985 Jul 8, 2022
6438dca
Updated changelog
zashraf1985 Jul 9, 2022
06f19ab
Merge branch 'master' into sherry/dependencies-version-updates
zashraf1985 Jul 11, 2022
c3ebca9
fixed fsc references
zashraf1985 Jul 11, 2022
c2a5ebf
testing FSC changes by pointing to my branch
zashraf1985 Jul 12, 2022
83a8de0
Revert "testing FSC changes by pointing to my branch"
zashraf1985 Jul 12, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/javascript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ jobs:
npm run lint

integration_tests:
uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@uzair/test-with-fsc
uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@master
secrets:
CI_USER_TOKEN: ${{ secrets.CI_USER_TOKEN }}
TRAVIS_COM_TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}

fullstack_production_suite:
uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@uzair/test-with-fsc
uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@master
with:
FULLSTACK_TEST_REPO: ProdTesting
secrets:
Expand All @@ -53,7 +53,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v3
with:
node-version: 8
node-version: 12
cache: 'npm'
cache-dependency-path: packages/optimizely-sdk/package-lock.json
- name: Cross-browser and umd unit tests
Expand All @@ -66,7 +66,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [ '8', '9', '10', '12', '14' ]
node: [ '12', '14', '16', '18' ]
steps:
- uses: actions/checkout@v3
- name: Set up Node ${{ matrix.node }}
Expand Down
11 changes: 10 additions & 1 deletion packages/optimizely-sdk/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

- Nothing yet!
### Changed
- Updated `murmurhash` dependency to version `2.0.1`.
- Updated `uuid` dependency to version `8.3.2`.
- Dropped support for the following browser versions.
- All versions of Microsof Internet Explorer.
- Chrome versions earlier than `102.0`.
- Microsoft Edge versions earlier than `84.0`.
- Firefox versions earlier than `91.0`.
- Opera versions earlier than `76.0`.
- Safari versions earlier than `13.0`.

## [4.9.2] - June 27, 2022

Expand Down
50 changes: 24 additions & 26 deletions packages/optimizely-sdk/karma.base.conf.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright 2018, 2020 Optimizely
* Copyright 2018, 2020, 2022 Optimizely
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -54,52 +54,50 @@ module.exports = {
customLaunchers: {
bs_chrome_mac: {
base: 'BrowserStack',
browser: 'chrome',
browser_version: '21.0',
os: 'OS X',
os_version: 'Mountain Lion',
os_version: 'Mojave',
browserName: 'Chrome',
browser_version: '102.0',
browser: 'Chrome',
},
bs_edge: {
base: 'BrowserStack',
os: 'Windows',
os_version: '10',
browser: 'edge',
device: null,
browser_version: '15.0',
},
bs_firefox_mac: {
base: 'BrowserStack',
browser: 'firefox',
browser_version: '21.0',
os: 'OS X',
os_version: 'Mountain Lion',
browserName: 'Edge',
browser_version: '84.0',
browser: 'Edge',
},
bs_ie: {
bs_firefox: {
base: 'BrowserStack',
os: 'Windows',
os_version: '7',
browser: 'ie',
device: null,
browser_version: '10.0',
browser: 'Firefox',
os_version: '10',
browserName: 'Firefox',
browser_version: '91.0',
},

bs_opera_mac: {
base: 'BrowserStack',
browser: 'opera',
browser_version: '37',
browser: 'Opera',
os_version: 'Mojave',
browserName: 'Opera',
browser: 'Opera',
browser_version: '76.0',
os: 'OS X',
os_version: 'Mountain Lion',
},
bs_safari: {
base: 'BrowserStack',
os: 'OS X',
os_version: 'Mountain Lion',
browser: 'safari',
os_version: 'Catalina',
browserName: 'Safari',
browser_version: '13.0',
browser: 'Safari',
device: null,
browser_version: '6.2',
},
},

browsers: ['bs_chrome_mac', 'bs_edge', 'bs_firefox_mac', 'bs_ie', 'bs_opera_mac', 'bs_safari'],
browsers: ['bs_chrome_mac', 'bs_edge', 'bs_firefox', 'bs_opera_mac', 'bs_safari'],

// frameworks to use
// available frameworks: https://npmjs.org/browse/keyword/karma-adapter
Expand Down
10 changes: 7 additions & 3 deletions packages/optimizely-sdk/lib/core/bucketer/index.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,14 @@ describe('lib/core/bucketer', function () {
expect(bucketer._generateBucketValue(bucketingKey4)).to.equal(5439);
});

it('should return an error if it cannot generate the hash value', function () {
assert.throws(function () {
it('should return an error if it cannot generate the hash value', function() {
const response = assert.throws(function() {
bucketer._generateBucketValue(null);
}, sprintf(ERROR_MESSAGES.INVALID_BUCKETING_ID, 'BUCKETER', null, "Cannot read property 'length' of null"));
} );
expect([
sprintf(ERROR_MESSAGES.INVALID_BUCKETING_ID, 'BUCKETER', null, "Cannot read property 'length' of null"), // node v14
sprintf(ERROR_MESSAGES.INVALID_BUCKETING_ID, 'BUCKETER', null, "Cannot read properties of null (reading \'length\')") // node v16
]).contain(response.message);
});
});

Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/fns/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import v4 from 'uuid';
import { v4 } from 'uuid';

const MAX_SAFE_INTEGER_LIMIT = Math.pow(2, 53);

Expand Down
Loading