Add feature toggleability at the variation level. #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
commented
Feb 8, 2018
| assert.isFunction(callArgs[1]); | ||
| sinon.assert.calledWith(createdLogger.log, LOG_LEVEL.INFO, 'OPTIMIZELY: Feature test_feature_for_experiment is enabled for user user1.'); | ||
| }); | ||
| it('returns true and dispatches an impression event', function() { |
There was a problem hiding this comment.
All of these test cases were actually just moved into the describe clause for when the variation is toggled ON on line 2495.
mikeproeng37
commented
Feb 8, 2018
lib/optimizely/index.tests.js
Outdated
| var result = optlyInstance.isFeatureEnabled('test_feature_for_experiment'); | ||
| assert.strictEqual(result, false); | ||
| sinon.assert.notCalled(eventDispatcher.dispatchEvent); | ||
| describe('when the variation is toggled OFF', function() { |
There was a problem hiding this comment.
These are the new test cases being added
mikeproeng37
commented
Feb 8, 2018
| experiment: experiment, | ||
| variation: variation, | ||
| decisionSource: DECISION_SOURCES.ROLLOUT, | ||
| describe('when the variation is toggled ON', function() { |
There was a problem hiding this comment.
These are also new test cases
mikeproeng37
commented
Feb 8, 2018
| it('returns true and does not dispatch an event', function() { | ||
| var result = optlyInstance.isFeatureEnabled('test_feature', 'user1', { | ||
| test_attribute: 'test_value', | ||
| describe('when the variation is toggled OFF', function() { |
mikeproeng37
force-pushed
the
mng/add-variation-level-toggleability
branch
from
8a1d43b to
d4c09d9
Compare
|
build |
3 similar comments
|
build |
|
build |
|
build |
wangjoshuah
approved these changes
Feb 15, 2018
mjc1283
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces toggleability for a feature flag at the variation level.