[FSSDK-9096] chore: Prepare release 5.0.0-beta #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
May 3, 2023
packages/optimizely-sdk/CHANGELOG.md
Outdated
| @@ -7,7 +7,49 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Breaking Changes | |||
| ## 5.0.0-beta.1 | |||
There was a problem hiding this comment.
5.0.0-beta to be consistent with other sdks?
There was a problem hiding this comment.
Updated to be consistent. This PR should pass all FSC tests minus two which involve firing queued events upon config change.
Upon further investigation, unsure if the FSC test should apply to the Browser variant as events are always immediately sent in a fire-and-forget method due to use of the Pixel API. Either way, will be publishing the Beta version as is, noting down all issues such as those, and addressing them in future patches.
opti-jnguyen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prepare for first v5 Beta Pre-release.
Test plan
Issues