Skip to content

[FSSDK-9562] refactor odp event api manager to handle odp config #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2023
Merged

[FSSDK-9562] refactor odp event api manager to handle odp config #844

merged 3 commits into from
Aug 11, 2023

Conversation

raju-opti
Copy link
Contributor

@raju-opti raju-opti commented Aug 10, 2023 •
edited
Loading

Summary

  • Refactor OdpEventApiManager to handle odp config update.

Test plan

  • Refactored affected existing tests
  • Added new tests for config udpates

Issues

  • FSSDK-9562

@raju-opti raju-opti requested a review from a team as a code owner August 10, 2023 20:38
@coveralls
Copy link

coveralls commented Aug 10, 2023 •
edited
Loading

Coverage Status

coverage: 90.437% (-0.09%) from 90.528% when pulling 022ec04 on raju/refactor-odp-event-api-man into 4cea2f1 on master.

@raju-opti raju-opti marked this pull request as draft August 10, 2023 20:45
@raju-opti raju-opti force-pushed the raju/refactor-odp-event-api-man branch from f407476 to 458a3c3 Compare August 11, 2023 15:11
@raju-opti raju-opti marked this pull request as ready for review August 11, 2023 15:17
mikechu-optimizely
mikechu-optimizely requested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts.

@raju-opti raju-opti force-pushed the raju/refactor-odp-event-api-man branch from 458a3c3 to 81e4916 Compare August 11, 2023 18:06
@raju-opti raju-opti removed their assignment Aug 11, 2023
mikechu-optimizely
mikechu-optimizely approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raju-opti raju-opti merged commit c4b8373 into master Aug 11, 2023
@raju-opti raju-opti deleted the raju/refactor-odp-event-api-man branch August 11, 2023 18:44
@mikechu-optimizely mikechu-optimizely mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @mikechu-optimizely