Skip to content

[FSSDK-8219] removed unnecessary subpackage dependency #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

raju-opti
Copy link
Contributor

Summary

  • remove js-sdk-datafile-manager subpackage from package.json

Test plan

  • existing tests should pass

Issues

  • FSSDK-8219

@coveralls
Copy link

Coverage Status

coverage: 90.437%. remained the same when pulling fc653a9 on raju/repo-package-root into c4b8373 on master.

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other refs

@mikechu-optimizely mikechu-optimizely changed the title [FSSDK-8219] removed unnecessary subpackage dependecny [FSSDK-8219] removed unnecessary subpackage dependency Aug 14, 2023
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change of ❤️🧠 LGTM

@raju-opti raju-opti merged commit 9384463 into master Aug 14, 2023
@raju-opti raju-opti deleted the raju/repo-package-root branch August 14, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants