Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9562] set pixel api endpoint dynamically #852

Merged
merged 2 commits into from Aug 17, 2023
Merged

[FSSDK-9562] set pixel api endpoint dynamically #852

merged 2 commits into from Aug 17, 2023

Conversation

raju-opti
Copy link
Contributor

Summary

  • Previously, pixel api endpoint was fixed. Now pixel api endpoint is generated dynamically from odp apiHost. This is needed cause pixel api endpoints are different for different odp regions.

Test plan

  • All existing tests should pass.

Issues

  • FSSDK-9562

@raju-opti raju-opti requested a review from a team as a code owner August 17, 2023 14:00
@coveralls
Copy link

coveralls commented Aug 17, 2023 •
edited

Coverage Status

coverage: 90.425% (-0.01%) from 90.437% when pulling 007be97 on raju/fix-pixel-endpoint into 91826b0 on master.

mikechu-optimizely
mikechu-optimizely requested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts/questions 👇

lib/plugins/odp/event_api_manager/index.browser.ts Show resolved Hide resolved
lib/plugins/odp/event_api_manager/index.browser.ts Show resolved Hide resolved
lib/plugins/odp/event_api_manager/index.browser.ts Outdated Show resolved Hide resolved
lib/plugins/odp/event_api_manager/index.browser.ts Show resolved Hide resolved
mikechu-optimizely
mikechu-optimizely approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raju-opti raju-opti merged commit 36ff5d7 into master Aug 17, 2023
14 checks passed
@raju-opti raju-opti deleted the raju/fix-pixel-endpoint branch August 17, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raju-opti @coveralls @mikechu-optimizely