Skip to content

[FSSDK-9605] add sendBeacon event dispatcher and test #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

raju-opti
Copy link
Contributor

Summary

  • porting sendBeacon dispatcher to v4. EventProcessor is a separate package in 4.x.x branch. Those changes will be pushed in a separate PR

Test plan

Issues

  • FSSDK-9605

@coveralls
Copy link

coveralls commented Oct 6, 2023

Coverage Status

coverage: 97.021%. remained the same when pulling 6b61113 on raju/send-beacon-4.x.x into 2c4865a on 4.x.x.

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -80,6 +80,7 @@
"sinon": "^2.3.1",
"ts-jest": "^23.10.5",
"ts-loader": "^7.0.5",
"ts-mockito": "^2.6.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love ts-mockito

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love ts-mockito

yeah, but it looks to be unmaintained though :(

@raju-opti raju-opti merged commit b1ec8c1 into 4.x.x Oct 9, 2023
@raju-opti raju-opti deleted the raju/send-beacon-4.x.x branch October 9, 2023 13:59
@raju-opti raju-opti restored the raju/send-beacon-4.x.x branch October 9, 2023 17:35
@raju-opti raju-opti deleted the raju/send-beacon-4.x.x branch February 4, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants