Skip to content

[FSSDK-10665] fix: Github Actions YAML files vulnerable to script injections corrected #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

FarhanAnjum-opti
Copy link
Contributor

Summary

Instead of directly using variables that can contain user input, new intermediate variables were introduced so that script injection attacks could be mitigated. Also default environment variables were used wherever possible.

Issues

@coveralls
Copy link

coveralls commented Sep 24, 2024

Coverage Status

coverage: 90.307%. remained the same
when pulling 7a3e70d on farhan/FSSDK-10665-github-actions-correction
into 093c3ca on master.

unnecessary assignment of default environment variable
renamed ALTERNATE_RELEASE_TAG to GITHUB_RELEASE_TAG
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FarhanAnjum-opti FarhanAnjum-opti merged commit e7cc602 into master Sep 25, 2024
19 checks passed
@FarhanAnjum-opti FarhanAnjum-opti deleted the farhan/FSSDK-10665-github-actions-correction branch September 25, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants