Feature - IP Anonymization #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:pen2: Added ip param in Event/Builder/EventBuilder.php :pen2: Changes to TestData.php :pen2: Changes in EventBuilderTest.php
|
Can one of the admins verify this patch? |
|
build |
|
Overall, this looks good. Our end to end SDK tests passed. Would it make sense to add tests for when |
|
This makes a simple assignment after parsing data file json. In my
opinion, adding tests for this would be an overkill. There are similar
assignments made such as revision, project id, account id. If you think
they are needed let me know, so I add one.
…On Thu, Oct 5, 2017 at 8:21 AM, Matt Auerbach ***@***.***> wrote:
Overall, this looks good. Our end to end SDK tests passed. Would it make
sense to add tests for when 'anonymize_ip=true ? I don't think I saw
those in EventBuilderTest.php
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANhOf8nyOmqdp91YkJx2H23U1BwkbuQ-ks5spEs4gaJpZM4PuIl->
.
--
Thanks
Owais Akbani
|
|
We don't need to check for |
|
Makes sense @oakbani . This LGTM then |
mauerbac
approved these changes
Oct 5, 2017
alda-optimizely
pushed a commit
that referenced
this pull request
Dec 8, 2017
* :pen2: IP Anonymization var and getter in ProjectConfig.php :pen2: Added ip param in Event/Builder/EventBuilder.php :pen2: Changes to TestData.php :pen2: Changes in EventBuilderTest.php * ✏️ Modifed var/method name
alda-optimizely
added a commit
that referenced
this pull request
Dec 15, 2017
* Feature - IP Anonymization (#64) * :pen2: IP Anonymization var and getter in ProjectConfig.php :pen2: Added ip param in Event/Builder/EventBuilder.php :pen2: Changes to TestData.php :pen2: Changes in EventBuilderTest.php * ✏️ Modifed var/method name * Fixed bucketing ID tests. (#66) * Cherry-picked notification listeners and IP anonymization features for 1.5.0 release. * 📝 sendImpressionEvent and TestData update (#80) * Make listener public (#79) * Updated the Changelog for 1.5.0 release. (#78) * Updated the Changelog for 1.5.0 release. * Added more description to the CHANGELOG. * Bumped release version to 1.5.0 * Changed the hard-coded test client_version reference to refer to the const defined in the EventBuilder class. * Bumped the test file to 1.5.0. * Bumped version for the event builder test. * Bumped event builder test client version number. * More client version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.