Updated the Changelog for 1.5.0 release. #78
Conversation
|
Can one of the admins verify this patch? |
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 1.5.0 | |||
| - Notification listeners. | |||
| - IP anonymization. | |||
There was a problem hiding this comment.
Please make these more descriptive like in previous releases.
There was a problem hiding this comment.
Perhaps
Added support for notification listeners.
Added support for IP anonymization.
|
build |
…const defined in the EventBuilder class.
| @@ -1,3 +1,7 @@ | |||
| ## 1.5.0 | |||
| - Added support for notification listeners. | |||
There was a problem hiding this comment.
Let's be consistent with adding the dates under the release notes
There was a problem hiding this comment.
None of the other releases have dates in this CHANGELOG. Also, when I land this, I don't know when I'm going to do the release after. If you want to do a shift, then I think we should do it for all future releases, across all SDKs.
|
build |
| @@ -69,7 +69,7 @@ public function setUp() | |||
| ]], | |||
| 'revision' => '15', | |||
| 'client_name' => 'php-sdk', | |||
| 'client_version' => '1.4.0', | |||
| 'client_version' => EventBuilder::SDK_VERSION, | |||
There was a problem hiding this comment.
This is intentionally kept like that so that it acts like a double check. Change this to 1.5.0
* Updated the Changelog for 1.5.0 release. * Added more description to the CHANGELOG. * Bumped release version to 1.5.0 * Changed the hard-coded test client_version reference to refer to the const defined in the EventBuilder class. * Bumped the test file to 1.5.0.
* Feature - IP Anonymization (#64) * :pen2: IP Anonymization var and getter in ProjectConfig.php :pen2: Added ip param in Event/Builder/EventBuilder.php :pen2: Changes to TestData.php :pen2: Changes in EventBuilderTest.php * ✏️ Modifed var/method name * Fixed bucketing ID tests. (#66) * Cherry-picked notification listeners and IP anonymization features for 1.5.0 release. * 📝 sendImpressionEvent and TestData update (#80) * Make listener public (#79) * Updated the Changelog for 1.5.0 release. (#78) * Updated the Changelog for 1.5.0 release. * Added more description to the CHANGELOG. * Bumped release version to 1.5.0 * Changed the hard-coded test client_version reference to refer to the const defined in the EventBuilder class. * Bumped the test file to 1.5.0. * Bumped version for the event builder test. * Bumped event builder test client version number. * More client version bump.
I'll cherry-pick this into 1.5.0 once this has been landed.