Skip to content

Conversation

junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented Aug 14, 2024

Summary

Test plan

  • Hook test suite is modified to fix some broken mocks and tests
  • Manual testing

Issues

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

No show-stoppers IMHO, but I have some curiosity questions 👇 DM me if it's easier.

@junaed-optimizely junaed-optimizely merged commit 2950991 into master Aug 15, 2024
9 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10544-refactor-hook-code branch August 15, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants