Skip to content

feat(attribute_value): Don't target NAN, INF, -INF and > 2^53 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2019
Merged

feat(attribute_value): Don't target NAN, INF, -INF and > 2^53 #148

merged 1 commit into from
Jan 2, 2019

Conversation

rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Jan 2, 2019 •
edited by nchilada
Loading

Summary

Don't target NAN, INF or -INF
Don't target Values > 2^53.
Modified attribute_valid? to check if the number is finite.

Test plan

Issues

OASIS-3655

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ca425d7 on rashid/-dont-target-nan-inf-1e53 into ad7e32b on rashid/audience-match-types.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ca425d7 on rashid/-dont-target-nan-inf-1e53 into ad7e32b on rashid/audience-match-types.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ca425d7 on rashid/-dont-target-nan-inf-1e53 into ad7e32b on rashid/audience-match-types.

mikeproeng37
mikeproeng37 approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 3990bf1 into rashid/audience-match-types Jan 2, 2019
@rashidsp rashidsp mentioned this pull request Jan 3, 2019
Merged
@rashidsp rashidsp deleted the rashid/-dont-target-nan-inf-1e53 branch January 9, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rashidsp @coveralls @mikeproeng37