-
Notifications
You must be signed in to change notification settings - Fork 28
feat (audience match types): Condition Evaluator, Project Config, and Audience combinations PRs consolidation. #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Results of running the Audience Match types tests from the compat-suite (they all pass!): https://travis-ci.com/optimizely/fullstack-sdk-compatibility-suite/jobs/168738056 |
rvm: | ||
- 2.3.7 | ||
- 2.4.4 | ||
- 2.5.1 | ||
before_install: gem install bundler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes:
ERROR: Error installing bundler:
bundler requires RubyGems version >= 3.0.0. Try 'gem update --system' to update RubyGems itself.
The command "gem install bundler" failed and exited with 1 during .```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -2,11 +2,14 @@ branch: | |||
only: | |||
- master | |||
language: ruby | |||
cache: bundler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juancarlostong can you review the changes to the travis file here? The details are in the description of the PR itself.
Summary
feat (audience match types): Update condition evaluator for new audience match types (feat (audience match types): Update condition evaluator for new audience match types. #145)
feat (audience match types): Update audience evaluator and project config for new audience match types (feat (audience match types): Update audience evaluator and project config for new audience match types. #146)
feat(audiences): Audience combinations (feat(audiences): Audience combinations #147)
feat(attribute_value): Don't target NAN, INF, -INF and > 2^53 (feat(attribute_value): Don't target NAN, INF, -INF and > 2^53 #148)
Build issue: