Skip to content

feat (audience match types): Condition Evaluator, Project Config, and Audience combinations PRs consolidation. #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 8, 2019

Conversation

rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Jan 3, 2019

Summary

Build issue:

@coveralls
Copy link

coveralls commented Jan 4, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 37872e6 on rashid/audience-match-types into e848bf5 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8453091 on rashid/audience-match-types into 360ca22 on master.

@mikeproeng37
Copy link
Contributor

Results of running the Audience Match types tests from the compat-suite (they all pass!): https://travis-ci.com/optimizely/fullstack-sdk-compatibility-suite/jobs/168738056

rvm:
- 2.3.7
- 2.4.4
- 2.5.1
before_install: gem install bundler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes:

ERROR:  Error installing bundler:
	bundler requires RubyGems version >= 3.0.0. Try 'gem update --system' to update RubyGems itself.
The command "gem install bundler" failed and exited with 1 during .```

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -2,11 +2,14 @@ branch:
only:
- master
language: ruby
cache: bundler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juancarlostong can you review the changes to the travis file here? The details are in the description of the PR itself.

@mikeproeng37 mikeproeng37 merged commit cd16893 into master Jan 8, 2019
@rashidsp rashidsp deleted the rashid/audience-match-types branch January 9, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants