Skip to content

[AQUA] Enhance get_config to Return Model Details and Configuration in a Pydantic format #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2025
Merged

[AQUA] Enhance get_config to Return Model Details and Configuration in a Pydantic format #1107

merged 3 commits into from
Mar 11, 2025

Conversation

mrDzurb
Copy link
Member

@mrDzurb mrDzurb commented Mar 11, 2025 •
edited
Loading

Description

This PR refactors the AQUA get_config method.

  • Previously, the method retrieved the config based on model_ocid by first fetching details from the Model Catalog, extracting the config location, and then loading and returning the config in dictionary format.
  • With this update, the method now returns both the model details and the config in a Pydantic format.

The model retrieved from Model Catalog will be reused across multiple places, reducing the need to repeatedly request model details.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 11, 2025
@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-19.48%

@mrDzurb mrDzurb changed the title Enhance get_config to Return Model Details and Configuration in a Pydantic Result Model [AQUA] Enhance get_config to Return Model Details and Configuration in a Pydantic format Mar 11, 2025
@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-19.48%

@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-94%

📌 Overall coverage:

Coverage-58.55%

@mrDzurb mrDzurb enabled auto-merge March 11, 2025 21:34
@mrDzurb mrDzurb merged commit 35c03c6 into main Mar 11, 2025
22 checks passed
@mrDzurb mrDzurb mentioned this pull request Mar 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayoor mayoor mayoor approved these changes

@qiuosier qiuosier qiuosier approved these changes

@darenr darenr Awaiting requested review from darenr darenr is a code owner

@VipulMascarenhas VipulMascarenhas Awaiting requested review from VipulMascarenhas VipulMascarenhas is a code owner

@ahosler ahosler Awaiting requested review from ahosler ahosler is a code owner

@lu-ohai lu-ohai Awaiting requested review from lu-ohai

@kumar-shivam-ranjan kumar-shivam-ranjan Awaiting requested review from kumar-shivam-ranjan

@vikasray0208 vikasray0208 Awaiting requested review from vikasray0208

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrDzurb @mayoor @qiuosier