Skip to content

ODSC-40388: improve class doc #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 21, 2023
Merged

ODSC-40388: improve class doc #112

merged 13 commits into from
Mar 21, 2023

Conversation

z7ye
Copy link
Contributor

@z7ye z7ye commented Mar 20, 2023

…eadme

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 20, 2023
@z7ye z7ye requested review from qiuosier and darenr March 20, 2023 23:47
darenr
darenr previously approved these changes Mar 20, 2023
@@ -25,16 +25,17 @@ followed by the spark version, 3.2.1.
with open(os.path.join(td, "script.py"), "w") as f:
f.write(
"""
import pyspark
import pyspark
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indent looks weird.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. fixed!

@z7ye z7ye requested a review from mingkang111 March 21, 2023 18:36
mingkang111
mingkang111 previously approved these changes Mar 21, 2023
@z7ye z7ye merged commit fe4ef2a into main Mar 21, 2023
@ahosler ahosler deleted the ODSC-40388/genericmodel_doc branch March 18, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants