Skip to content

Exclude the streaming environment variable when creating model deployments. #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 5, 2025

Conversation

mrDzurb
Copy link
Member

@mrDzurb mrDzurb commented May 12, 2025

Description

Updated logic to exclude the streaming environment variable when creating model deployments within AQUA

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 12, 2025
Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-58.62%

Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-58.62%

Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-58.62%

Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-58.65%

@mrDzurb mrDzurb changed the title Exclude the streaming environment variable when creating model deployments. [Do Not Merge] Exclude the streaming environment variable when creating model deployments. May 16, 2025
Copy link

@saurabhskj saurabhskj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚢

@mrDzurb mrDzurb changed the title [Do Not Merge] Exclude the streaming environment variable when creating model deployments. Exclude the streaming environment variable when creating model deployments. Jun 4, 2025
Copy link
Member

@VipulMascarenhas VipulMascarenhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@mrDzurb mrDzurb requested a review from VipulMascarenhas June 5, 2025 04:45
Copy link

github-actions bot commented Jun 5, 2025

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-56.85%

Copy link

github-actions bot commented Jun 5, 2025

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-58.56%

@mrDzurb mrDzurb merged commit dfe2197 into main Jun 5, 2025
22 checks passed
Copy link

github-actions bot commented Jun 5, 2025

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-58.43%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants