[ODSC-76829/76830] : improve auto-select logic and handle missing data #1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
oracle-contributor-agreement
bot
added
the
OCA Required
codeloop
force-pushed
the
vikaspa/fix-auto-select
branch
from
250585d to
a57b872
Compare
oracle-contributor-agreement
bot
added
OCA Verified
codeloop
changed the title
codeloop
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
codeloop
changed the title
ahosler
requested changes
Sep 18, 2025
| if target_col not in data.columns: | ||
| raise ValueError(f"Target column '{target_col}' not found in DataFrame") | ||
|
|
||
| data[target_col] = data[target_col].fillna(0) |
There was a problem hiding this comment.
why fillna with 0? why no backfill? Did we discuss this?
Don't we already have this covered in pre-processing steps? What are we gaining from this?
| ): | ||
|
|
||
| operator_config.spec.model = AUTO_SELECT | ||
| model = ForecastOperatorModelFactory.get_model(operator_config, datasets) |
There was a problem hiding this comment.
nice!
Can we reflect this in the report? Make sure it's still saying "auto-select-series".
Can we add a unit test for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve auto-select logic and handle missing data
This commit introduces following to the forecasting operator.
Improved
AUTO_SELECT_SERIESLogic:AUTO_SELECTmodel has been implemented for cases whereAUTO_SELECT_SERIESis used without specifyingtarget_category_columns.Missing Data Handling:
build_fforms_meta_featuresfunction now fills missing values in the target column with zeros. This prevents errors during meta-feature calculation when the data contains NaNs.New Test Case:
auto-select-seriesmodel functions correctly with datasets containing missing values.