Skip to content

ODSC-50530: Pack recommended infra config into operator yaml #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 30, 2023
Merged

ODSC-50530: Pack recommended infra config into operator yaml #467

merged 25 commits into from
Nov 30, 2023

Conversation

mrDzurb
Copy link
Member

@mrDzurb mrDzurb commented Nov 30, 2023

Description

https://jira.oci.oraclecorp.com/browse/ODSC-50530

Allows to pack recommended infra config into the MLoperator YAML.

Example:
The jobs_default_params section was added for the forecasting operator.

type: forecast
version: v1
name: Forecasting Operator
conda_type: published
conda: forecast_v1
gpu: no
jobs_default_params:
  shape_name: VM.Standard.E4.Flex
  ocpus: 32
  memory_in_gbs: 512
  block_storage_size_in_GBs: 512

backends:
  - job

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 30, 2023
@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-24.24%

ahosler
ahosler previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@ahosler ahosler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@ahosler ahosler self-requested a review November 30, 2023 15:25
@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-24.24%

@mrDzurb mrDzurb requested a review from liudmylaru November 30, 2023 21:35
@mrDzurb mrDzurb merged commit c20b4d8 into main Nov 30, 2023
@ahosler ahosler deleted the ODSC-50530/operator_recommended_config branch March 18, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahosler ahosler ahosler approved these changes

@liudmylaru liudmylaru liudmylaru approved these changes

@prasankh prasankh Awaiting requested review from prasankh

@codeloop codeloop Awaiting requested review from codeloop

@govarsha govarsha Awaiting requested review from govarsha

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrDzurb @ahosler @liudmylaru