-
Notifications
You must be signed in to change notification settings - Fork 56
Optimised report loading for anomaly operator #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahosler
reviewed
Jul 3, 2024
ahosler
reviewed
Jul 3, 2024
ahosler
previously approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
VipulMascarenhas
previously approved these changes
Jul 3, 2024
mrDzurb
previously approved these changes
Jul 3, 2024
f94fd9d
ahosler
approved these changes
Jul 9, 2024
VipulMascarenhas
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made following changes to optimise report loading for anomaly detector:
Results:
I have used cpu_utilization_asg_misconfiguration.csv from NAB which has 18051 data points.
Report without optimisation:


Loading time - 15 seconds
Size - 6.2MB
Report with optimisation:


Loading time - 2/3 seconds
Size - 411KB