Cancel job run only if it is in cancellable state when force deleting a job #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuosier
requested review from
darenr,
mayoor,
mrDzurb and
VipulMascarenhas
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
VipulMascarenhas
approved these changes
Jul 22, 2024
|
📌 Cov diff with main: 📌 Overall coverage: |
lu-ohai
approved these changes
Jul 23, 2024
|
📌 Cov diff with main: No lines with coverage information in this diff. 📌 Overall coverage: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a job, there is an option to
force_deleteall job runs. However, job run can only be cancelled if it is "in progress", "accepted" or "need attention". Otherwise there will be error. This PR updates the ADS to cancel only the job runs that can be cancelled. There is no need to a cancel job run before deleting if it is in other states.