-
Notifications
You must be signed in to change notification settings - Fork 57
[ODSC-60499] Update validation for models registered from object storage #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ODSC-60499] Update validation for models registered from object storage #915
Conversation
If the container selected is odsc-llama-cpp-serving while registering and the artifact has only gguf files no safetensor, there shouldn't be check for config.json right? bt in the current implementation , it is doing and if there is no config.json found, it is throwing error. |
the exception wasn't handled correctly in that case, it's fixed now. thanks for catching this. |
# Download the model from hub | ||
model_name = import_model_details.model | ||
local_dir = import_model_details.local_dir | ||
if not local_dir: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: we're downloading to cached folder first and then to local folder. Need to test this two step download, most likely we just need to download to local dir.
Description
This PR covers the following changes:
Request
Response
Unit Tests
Tests will be covered in a separate PR.