Skip to content

VisualVM is not showing V1 gRPC Connections #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ public List<Entry<Object, Data>> getData(RequestSender requestSender, Class<?> c
// manual check as version numbering changed after 35
nVersion = 353;
}
else if (sCoherenceVersion.startsWith("2"))
else if (sCoherenceVersion.startsWith("2") || sCoherenceVersion.startsWith("3"))
{
// check for versions such as 20.06 or 20.06.01 and convert them to an ever-increasing number
// 20.06 -> 2006000
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,13 @@ public void dumpClusterHeap(String sRole) throws Exception
new String[] {String.class.getName()});
}

public Set<ObjectName> getV1GrpcProxyMBean()
throws Exception
{
return f_connection.queryNames(new ObjectName("Coherence:type=GrpcProxy,*"), null);
}


@Override
public String[] getSnapshots(String sService, String sDomainPartition)
throws Exception
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,15 @@

import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.SortedMap;
import java.util.logging.Logger;

import com.oracle.coherence.plugin.visualvm.VisualVMModel;
import com.oracle.coherence.plugin.visualvm.helper.HttpRequestSender;
import com.oracle.coherence.plugin.visualvm.helper.JMXRequestSender;
import com.oracle.coherence.plugin.visualvm.helper.RequestSender;
import javax.management.ObjectName;

/**
* A class to hold basic gRPC Proxy data.
Expand Down Expand Up @@ -79,11 +82,38 @@ public Data processReporterData(Object[] aoColumns, VisualVMModel model)
data.setColumn(RESPONSES_SENT_COUNT, Long.valueOf(getNumberValue(aoColumns[nStart++].toString())));
data.setColumn(MESSAGES_RECEIVED_COUNT, Long.valueOf(getNumberValue(aoColumns[nStart++].toString())));
data.setColumn(REQUEST_DURATION_MEAN, Float.parseFloat(aoColumns[nStart++].toString()));
data.setColumn(MESSAGE_DURATION_MEAN, Float.parseFloat(aoColumns[nStart++].toString()));
data.setColumn(MESSAGE_DURATION_MEAN, Float.parseFloat(aoColumns[nStart].toString()));

return data;
}

@Override
public String preProcessReporterXML(VisualVMModel model, String sReporterXML)
{
String sMBeanName = "GrpcNamedCacheProxy"; // v0 default

try {
// determine if v0 or v1 of gRPC proxy is being used.
RequestSender requestSender = model.getRequestSender();
if (requestSender instanceof JMXRequestSender)
{
// check for JMX MBean of type Coherence:type=GrpcProxy
JMXRequestSender jmxRequestSender = (JMXRequestSender) requestSender;
Set<ObjectName> setNames = jmxRequestSender.getV1GrpcProxyMBean();
if (setNames != null && !setNames.isEmpty())
{
sMBeanName = "GrpcProxy";
}
}
}
catch (Exception eIgnore)
{
// ignore
}

return sReporterXML.replaceAll("%MBEAN%", escape(sMBeanName));
}

@Override
public SortedMap<Object, Data> getAggregatedDataFromHttpQuerying(VisualVMModel model,
HttpRequestSender requestSender)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<delim>{tab}</delim>

<query>
<pattern>Coherence:type=GrpcNamedCacheProxy,*</pattern>
<pattern>Coherence:type=%MBEAN%,*</pattern>
<filter-ref>equals</filter-ref>
</query>

Expand Down