-
Notifications
You must be signed in to change notification settings - Fork 12
Vite migration and dependency updates #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I have a few request:
-
Update the description of this MR to include a link to the adoption of the vite puglin guidelines and to describe exactly what changed in the project.
-
Update the Start the dev server section of the readme to reflect the current behavior of the server.
I am not sure if we should bump the version of this template, lets have that discussion with Antonio once the requested changes are implemented.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@oiramS you mean the version in the |
understood, lets keep it as |
Vite migration and dependency updates
What changed
<LiveReload />
component from theroot.tsx
file.root.tsx
file.tsconfigPaths()
plugin in vite to support the use of ~ in our file imports.<Link />
components, changed the route to include../
at the beginning of a path.build
,start
anddev
scripts in thepackage.json
to use Vite.postcss.config.mjs
file to support the use of tailwind with Vite.This PR also contains dependency updates for the following dependencies:
One quick note on both of the mui dependencies. Although it appears we are downgrading, we can find that 5.16.14 is the latest release in their releases list: https://github.com/mui/material-ui/releases
Upgrading to any MUI version starting with a 6 ends with the project being riddled with hydration errors and breaking the whole thing. Once React v19.0.0 is compatible with Remix, we can upgrade to MUI 6.
Updated the dependencies listed above in the package.json file of the ords-remix-jwt-sample template.
Generated a new project from that template.
Executed the dev command of the project and confirmed that there were no import errors.
Did a full scan of the project and confirmed that everything worked as expected.
Checklist: