Pushed SOA BPM docker images #482

ykotecha · 2017-07-17T12:46:55Z

Please review SOA, OSB and BPM docker files. Thanks.

Djelibeybi

You are relying on the Docker Compose sample to switch between the SOA/BPM and Admin/Managed server types, but you don't document how to do it manually for users who don't use Compose or want to use an alternative orchestration system like Kubernetes.

Further, it relies on manually calling a specific command. You should rather accept a runtime environment variable (e.g. soaas, soams, etc) and a single script called by CMD should configure and/or start the right server.

Then, the compose file just needs to set the right ENV variable.

Djelibeybi · 2017-07-17T13:13:17Z

OracleSOABPM/dockerfiles/12.2.1.2-soabpm/Dockerfile

+#
+# Pull base image
+# ---------------
+FROM container-registry.oracle.com/java/serverjre:8u131


This needs to be changed to FROM oracle/serverjre:8.

I did not see 8 in container-registry - that is why used this so that we can pull an already existing certified image. Can be changed easily, but local tags would need to be done then.

There is definitely an 8 in the Container Registry, but either way, you need to use oracle/serverjre:8 for Dockerfiles in this repo.

FIXED. We are now inheriting from the FMW Infra Image.

Djelibeybi · 2017-07-17T13:13:43Z

OracleSOABPM/dockerfiles/12.2.1.2-soabpm/Dockerfile

+#
+# Environment variables required for this build (do NOT change)
+# -------------------------------------------------------------
+USER root


This line isn't necessary.

Djelibeybi · 2017-07-17T13:16:04Z

OracleSOABPM/dockerfiles/12.2.1.2-soabpm/Dockerfile

+# Copy Domain creation scripts
+#
+USER root
+COPY container-scripts/* /u01/oracle/dockertools/


Move lines 84-85 to after line 72 so that you don't have to switch between root and oracle.

Djelibeybi · 2017-07-17T13:16:22Z

OracleSOABPM/dockerfiles/12.2.1.2-soabpm/Dockerfile

+#
+# Define default command to start bash.
+#
+USER oracle


If lines 84-85 are moved, you don't need to switch back to oracle here.

The reason for the switch was we found that everytime there is a change in one of our scripts an entire reinstall was done as the layer was marked as changed - so the cache was invalidated. This resulted in a really long build time for each minor change in the script. By doing this we get the benefit of caching. The developer will face this too, which could be an issue. The reason for the change was a much better user experience.

Just as a reference point if we made a change to container-scripts directory which is primarily where all code is, if we did not split it up a build takes around 900 seconds, whereas with this shift it comes down to about 100 seconds.

Once your PR is merged, your scripts wouldn't change, so this is not impacted. Besides, making an efficient image with the least amount of layers is better than jumping between users and layers.

We had exactly this before - and it was just becoming difficult to iterate locally. I assume after merging the developer is likely to change the scripts - so they will face the issue if they do this. It is a simple change so it can be done - but I wanted to make sure you understand the rationale.

Why would a developer be likely to change these scripts after merge? That bit I don't understand. These scripts should be production-ready and not require any modification after merging.

Djelibeybi · 2017-07-17T13:20:55Z

OracleSOABPM/dockerfiles/README.md

+     if you have an internal proxy - ensure that the proxy
+     related env variables are set    
+     http_proxy, https_proxy, no_proxy
+   - Pull the base image into your local docker cache for builds.


The preferred mechanism for manually building images is to manually build the base image. See the WebLogic Dockerfiles for examples on how to either manually build the oracle/serverjre image or pull it from the Oracle Container Registry or Docker Store and tag it accordingly.

Djelibeybi · 2017-07-17T13:21:48Z

OracleSOABPM/dockerfiles/README.md

+     You will need to provide your login credentials.
+
+    ```sh
+docker pull container-registry.oracle.com/java/serverjre:8u131


Specifying 8u131 is too specific, because it will lock users into a JRE version that won't be updated. You should specify 8 instead so that when the JRE is updated, any subsequent builds of SOA/BPM will use the updated JRE as well.

I did not see 8 in container-registry - that is why used this so that we can pull an already existing certified image.

It's there. :)

Easy change.

FIXED. No longer applicable as we use the FMWInfra Image.

Djelibeybi · 2017-07-17T13:23:51Z

OracleSOABPM/setenv.sh

+  export DC_ORCL_OEM_PORT=5500
+  export DC_ORCL_SID=soadb
+  export DC_ORCL_PDB=soapdb
+  export DC_ORCL_SYSPWD=welcome1


We don't allow hard-coded passwords anywhere. This needs to be changed to either accept a password or dynamically generate one.

We support auto password generation - we can remove this.

mriccell

Extend the FMW Infra image instead of reinstalling the same binaries!

mriccell · 2017-07-17T14:27:01Z

OracleSOABPM/dockerfiles/12.2.1.2-soabpm/Dockerfile

+#
+# Pull base image
+# ---------------
+FROM container-registry.oracle.com/java/serverjre:8u131


Why are you not extending the FMW Infrastructure image, taking advantage of the layering instead of reinstalling the same binaries here?

Our Quickstart installers already include FMW infrastructure in them - so they directly do the install. Otherwise it will be a double install.

Do you have alternative installers that don't include FMW infrastructure? If so, can you use those instead?

Yes, but that is a lot of separate installers - this was built purely on the request of customers as they wanted to get done in a single download.

Customers are going to build this once and then distribute internally. The images we provide on OCR and other registries will be built off the FMW Infrastructure image. This needs to change to inherit from FMW Infrastructure, because that's exactly what it was designed for: to be the base for SOA/BPM/OSB.

FIXED. We are now inheriting from the FMW Infra Image. We need the official coordinates to use in the FROM tag. Please provide that. Currently using
FROM middleware/weblogic:12.2.1.2-infrastructure

mriccell

Is this meant to run in a multi host env? If so how do you address the mapping of the domain to a host dir? Maybe the mapping should be to a data container that is in the overlay folder.

mriccell · 2017-07-17T14:34:29Z

OracleSOABPM/setenv.sh

+  #
+  # RCU Common password for all schemas + Prefix Names
+  #
+  export DC_RCU_SCHPWD=welcome1


Same as above, passwords can not be hardcoded

mriccell · 2017-07-17T14:41:52Z

OracleSOABPM/dockerfiles/README.md

+     related env variables are set    
+     http_proxy, https_proxy, no_proxy
+   - Pull the base image into your local docker cache for builds.
+     You will need to provide your login credentials.


Can you provide more details about what credentials need to be provided?

This shouldn't be required if the primary documentation states that the oracle/serverjre:8 is manually built using the Dockerfile from the repo, instead of being pulled from OCR or Docker Store.

This is more an internal thing here - though users may face it too. Basically the proxy values not being set results in very slow downloads as it contacts the proxy for internal URLs too. This is again generic stuff that we found along the way as we were doing work - and documented it for others that may run into the same issue.

Please make sure the Dockerfiles and scripts here work for the non-employee user.

Yes they will. OracleSOABPM renamed to OracleSOASuite.

mriccell · 2017-07-17T14:46:15Z

OracleSOABPM/samples/README.md

+docker logs -f soaas
+    ```
+  - Verify Admin Server  
+    http://host.acme.com:7001/console (weblogic/welcome1)


How do you set the host to be always host.acme.com? How is the admin password becoming welcome1 if it is auto-generated. You want to make in the dockerfile the ADMIN_PASSWORD an ENV and allow the user if they do not want the autop generated password to over-write with a -e option.

These are just examples for the user. They need to substitute their actual values (of host and username/password etc)

If they're examples, then the documentation needs to be more explicit about that and what the user needs to replace them with.

We will just remove it.

brunoborges

Please rename folder from OracleSOABPM to OracleSOASuite.

brunoborges · 2017-07-18T01:58:28Z

OracleSOABPM/dockerfiles/README.md

+     related env variables are set    
+     http_proxy, https_proxy, no_proxy
+   - Pull the base image into your local docker cache for builds.
+     You will need to provide your login credentials.


Please make sure the Dockerfiles and scripts here work for the non-employee user.

Djelibeybi

Great work, thanks. Just need @mriccell and @brunoborges to sign off too.

brunoborges

Suite! (pun intended)...
LGTM

Pushed SOA BPM docker images

1644a79

ykotecha requested review from brunoborges and Djelibeybi as code owners July 17, 2017 12:46

Djelibeybi requested a review from mriccell July 17, 2017 13:11

Djelibeybi suggested changes Jul 17, 2017

View reviewed changes

Djelibeybi added the enhancement label Jul 17, 2017

mriccell requested changes Jul 17, 2017

View reviewed changes

brunoborges suggested changes Jul 18, 2017

View reviewed changes

Addressed review comments

50ac276

Djelibeybi approved these changes Jul 19, 2017

View reviewed changes

brunoborges approved these changes Jul 19, 2017

View reviewed changes

Djelibeybi merged commit 5deb063 into oracle:master Jul 19, 2017

Pushed SOA BPM docker images #482

Pushed SOA BPM docker images #482

Uh oh!

Conversation

ykotecha commented Jul 17, 2017

Uh oh!

Djelibeybi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mriccell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mriccell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment