[GR-64855] Remove JDK 21 code guarded by JavaVersionUtil.JAVA_SPEC from Native Image #11173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
je/svm-jdk21-cleanup-GR-64855_javaversionutil
branch
from
9b3238f to
233930a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK 21 support was dropped in #11141, so we can cleanup the native image code base.
This PR removes JDK 21 code guarded by
JavaVersionUtil.JAVA_SPEC <= 21or similar checks. In addition, some simple refactorings were done like replacing reflection with direct calls whenever possible.Reviewers: Please have a close look at the removed branches. We have many different conditions variants and it is just too easy to delete the wrong branch. I did many of the changes with the help of the IDE refactoring tools. Never the less, please pay attention.
See also: