[GR-68465] Small size optimization for MultiTypeState #12262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a dual representation for
MultiTypeState
that uses a compact array for small sets and aBitSet
for larger ones, reducing memory footprint when operating with small sets. The switch between representations is controlled by new configurable thresholds (MultiTypeStateArrayBitSetThreshold
andMultiTypeStateArrayBitSetIntersectionSpeculationThreshold
), Union, intersection, and subtraction now have fast array-based paths with optimistic merge strategies, falling back toBitSet
when results exceed the threshold. Cross-representation operations are supported and optimized to avoid unnecessary conversions where possible. Memory reporting is updated to reflect the new representations and provide more accurate accounting.The analysis time and total buid time does not seem to be impacted, which is in a way expected, since the
TypeState
operations form only a small part of theanalysis
phase workload at the moment (Most of the time is spend parsing and optimizing). However, the impact on allocation rate is significant for bigger images, see the result onSpring Petclinic
below obtained with-H:+PrintTypeStateMemoryFootprint
(~3x reduction).Before:
With MultiTypeStateWithArray: