Remove unneeded deps #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langchain-openai is not a direct dependency, and is only needed when running an OpenAI compatible model with data science service deployment oracle-ads is also only needed when using Data Science deployment. These are optional requirements
oracle-contributor-agreement
bot
added
the
OCA Verified
|
@YouNeedCryDear |
|
I think it is OK to remove oracle-ads and langchain-openai as dependencies at the top level. They are not needed if users only want to use the OCI generative AI service. Users will be prompted (here for langchain-openai and here for oracle-ads) to install them if they uses OCI ModelDeployment. Maybe we can also make them as optional dependencies. |
|
@YouNeedCryDear |
YouNeedCryDear
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several dependencies that should be optional (ads, langchain-openai)
and there are several version requirements that are very stringent and require old apps to be upgraded for lots of packages, making it complicated to switch from the langchain-community version seamlessly