fix: do not use download script for Syft #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
tromai
reviewed
Apr 17, 2023
| rm -f "$CHECKSUMS" | ||
|
|
||
| # Check if artifact is valid. | ||
| if [ "$EXPECTED" == "$SYFT_DIGEST" ]; then |
There was a problem hiding this comment.
Should we perform this checking before extracting the tarball as we haven't trusted it yet?
There was a problem hiding this comment.
Should we perform this checking before extracting the tarball as we haven't trusted it yet?
Good point. See commit 46141d6.
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
tromai
approved these changes
Apr 17, 2023
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Scorecard report we should avoid
downloadThenRunpatterns because we won't have a chance to review the download script before running it.Also see this discussion.