-
Notifications
You must be signed in to change notification settings - Fork 28
chore: improve logger config and error codes #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
There is a warning on the Python documentation on the exit codes - https://docs.python.org/3/library/os.html#os._exit
Does it mean that we need to first check whether those constants are available before we use it? Reference - https://stackoverflow.com/a/57464811 |
Not really. We are expecting Macaron to work on Linux and MacOS. I'll adjust the classifier to reflect that. |
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
See commit 27cbd73. |
os.makedirs(args.output_dir) | ||
|
||
# Add file handler to the root logger. Remove stream handler from the | ||
# root logger to prevent dependencies printing logs to stdout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By dependencies
, do you mean the Python third-party dependencies that we have for Macaron?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By
dependencies
, do you mean the Python third-party dependencies that we have for Macaron?
Yes, for example SQLAlchemy.
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
No description provided.