Skip to content

Conversation

behnazh-w
Copy link
Member

No description provided.

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 20, 2023
@behnazh-w behnazh-w marked this pull request as ready for review April 20, 2023 06:38
@behnazh-w behnazh-w requested a review from tromai as a code owner April 20, 2023 06:38
@tromai
Copy link
Member

tromai commented Apr 21, 2023

There is a warning on the Python documentation on the exit codes - https://docs.python.org/3/library/os.html#os._exit
The documentation says:

Note

Some of these may not be available on all Unix platforms, since there is some variation. These constants are defined where they are defined by the underlying platform.

Does it mean that we need to first check whether those constants are available before we use it? Reference - https://stackoverflow.com/a/57464811

@behnazh-w
Copy link
Member Author

Does it mean that we need to first check whether those constants are available before we use it?

Not really. We are expecting Macaron to work on Linux and MacOS. I'll adjust the classifier to reflect that.

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w
Copy link
Member Author

I'll adjust the classifier to reflect that.

See commit 27cbd73.

os.makedirs(args.output_dir)

# Add file handler to the root logger. Remove stream handler from the
# root logger to prevent dependencies printing logs to stdout.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By dependencies, do you mean the Python third-party dependencies that we have for Macaron?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By dependencies, do you mean the Python third-party dependencies that we have for Macaron?

Yes, for example SQLAlchemy.

@behnazh-w behnazh-w merged commit e1dea3c into staging Apr 21, 2023
@behnazh-w behnazh-w added this to the Release v0.1.0 milestone Apr 21, 2023
@behnazh-w behnazh-w self-assigned this Apr 21, 2023
@behnazh-w behnazh-w deleted the fix-logger branch April 24, 2023 08:19
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants