Skip to content

Conversation

behnazh-w
Copy link
Member

@behnazh-w behnazh-w commented Jun 13, 2023

This PR changes the data model in Macaron to analyze at software component level using PURL as the identifier instead of repository level analysis. In this new data model, it is allowed to miss a repository associated with a component, closing this issue.

In addition, it closes this issue by changing the database transactions to guarantee atomicity per analysis, i.e., if anything goes wrong and the analysis fails unexpectedly, no changes will be added to the database.

In this first PR the input is still a repository, and a PURL is constructed from the repository provided as input. In a subsequent PR, we will add support for PURL identifier to be provided as a CLI input.

Here is the new ERD for Macaron:
image

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 13, 2023
@behnazh-w behnazh-w force-pushed the 187-allow-main-analysis-target-be-null-in-the-data-model branch from 1e8fb99 to 21816f9 Compare June 14, 2023 00:44
@behnazh-w behnazh-w mentioned this pull request Jun 14, 2023
3 tasks
@behnazh-w behnazh-w self-assigned this Jun 14, 2023
@behnazh-w behnazh-w force-pushed the 187-allow-main-analysis-target-be-null-in-the-data-model branch 3 times, most recently from 7125b6e to c7bd76f Compare June 17, 2023 00:23
@behnazh-w behnazh-w force-pushed the 187-allow-main-analysis-target-be-null-in-the-data-model branch 4 times, most recently from 07532d9 to 266700e Compare July 4, 2023 05:58
@behnazh-w behnazh-w force-pushed the 187-allow-main-analysis-target-be-null-in-the-data-model branch 3 times, most recently from 00f2042 to 9fce105 Compare July 17, 2023 05:39
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w behnazh-w marked this pull request as ready for review July 23, 2023 23:56
behnazh-w added 13 commits July 24, 2023 11:29
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w behnazh-w force-pushed the 187-allow-main-analysis-target-be-null-in-the-data-model branch from 0830330 to 6b3eb24 Compare July 24, 2023 07:06
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w behnazh-w changed the title feat: introduce a new data model and software components based on PURL feat!: introduce a new data model and software components based on PURL Jul 25, 2023
@behnazh-w behnazh-w requested a review from tromai July 25, 2023 00:43
@behnazh-w behnazh-w merged commit c6a48a3 into staging Jul 25, 2023
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
…RL (#305)

This PR changes the data model in Macaron to analyze at software component level using [PURL](https://github.com/package-url/purl-spec) as the identifier instead of repository level analysis. In this new data model, it is allowed to miss a repository associated with a component, closing this [issue](#187).

In addition, it closes this [issue](#115) by changing the database transactions to guarantee atomicity per analysis, i.e., if anything goes wrong and the analysis fails unexpectedly, no changes will be added to the database.

In this PR the input is still a repository, and a PURL is constructed from the repository provided as input. In a subsequent PR, we will add [support for PURL identifier to be provided as a CLI input](#375).

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants