generated from oracle/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 28
feat!: introduce a new data model and software components based on PURL #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
behnazh-w
merged 23 commits into
staging
from
187-allow-main-analysis-target-be-null-in-the-data-model
Jul 25, 2023
Merged
feat!: introduce a new data model and software components based on PURL #305
behnazh-w
merged 23 commits into
staging
from
187-allow-main-analysis-target-be-null-in-the-data-model
Jul 25, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e8fb99
to
21816f9
Compare
7125b6e
to
c7bd76f
Compare
07532d9
to
266700e
Compare
This was referenced Jul 5, 2023
00f2042
to
9fce105
Compare
tromai
reviewed
Jul 19, 2023
tromai
reviewed
Jul 19, 2023
tromai
reviewed
Jul 19, 2023
tromai
reviewed
Jul 20, 2023
tromai
reviewed
Jul 20, 2023
tromai
reviewed
Jul 20, 2023
tromai
reviewed
Jul 20, 2023
tromai
reviewed
Jul 20, 2023
tromai
reviewed
Jul 21, 2023
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
tromai
reviewed
Jul 21, 2023
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
0830330
to
6b3eb24
Compare
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
tromai
approved these changes
Jul 24, 2023
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
tromai
approved these changes
Jul 25, 2023
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
…RL (#305) This PR changes the data model in Macaron to analyze at software component level using [PURL](https://github.com/package-url/purl-spec) as the identifier instead of repository level analysis. In this new data model, it is allowed to miss a repository associated with a component, closing this [issue](#187). In addition, it closes this [issue](#115) by changing the database transactions to guarantee atomicity per analysis, i.e., if anything goes wrong and the analysis fails unexpectedly, no changes will be added to the database. In this PR the input is still a repository, and a PURL is constructed from the repository provided as input. In a subsequent PR, we will add [support for PURL identifier to be provided as a CLI input](#375). Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the data model in Macaron to analyze at software component level using PURL as the identifier instead of repository level analysis. In this new data model, it is allowed to miss a repository associated with a component, closing this issue.
In addition, it closes this issue by changing the database transactions to guarantee atomicity per analysis, i.e., if anything goes wrong and the analysis fails unexpectedly, no changes will be added to the database.
In this first PR the input is still a repository, and a PURL is constructed from the repository provided as input. In a subsequent PR, we will add support for PURL identifier to be provided as a CLI input.
Here is the new ERD for Macaron:
