Skip to content

Conversation

behnazh-w
Copy link
Member

@behnazh-w behnazh-w commented Feb 8, 2023

This PR refactors the build tools and dependency analyzer and adds a feature to automatically detect Gradle dependencies and map them to their SCM repositories.

As part of the refactoring, this PR also fixes related issues to dependency analyzer and adds back two skipping dependencies.

For now the integration test for Gradle dependency analysis is disabled due to a non-deterministic behavior of CycloneDX Gradle plugin. This issue will be addressed separately in #60.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 8, 2023
@behnazh-w behnazh-w changed the title frat: add dependency analyzer for Gradle feat: add dependency analyzer for Gradle Feb 8, 2023
@behnazh-w behnazh-w force-pushed the add-gradle-dep-analyzer branch 4 times, most recently from 8e461e7 to 75da042 Compare February 9, 2023 10:16
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w behnazh-w force-pushed the add-gradle-dep-analyzer branch from 75da042 to 9a75df8 Compare February 13, 2023 21:33
tool_version : str
The version of the dependency analyzer.
repo_path: str
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This attribute is only needed for the CycloneDxMaven class for now. Do you think it is a good idea to move it there? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a general enough attribute that would be useful for other dependency resolvers down the road?

@behnazh-w
Copy link
Member Author

behnazh-w commented Feb 16, 2023

@tromai addressed comments in b72bde3

@behnazh-w behnazh-w force-pushed the add-gradle-dep-analyzer branch from 78c34e8 to ef21f49 Compare February 16, 2023 01:54
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w behnazh-w force-pushed the add-gradle-dep-analyzer branch from ef21f49 to b72bde3 Compare February 16, 2023 01:56
@tromai
Copy link
Member

tromai commented Feb 16, 2023

@tromai addressed comments in b72bde3

LGTM

@behnazh-w behnazh-w merged commit ecc2162 into staging Feb 16, 2023
@behnazh-w behnazh-w deleted the add-gradle-dep-analyzer branch April 19, 2023 05:15
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
* feat: add dependency analyzer for Gradle
* chore: add dependencies for repos with sub-projects
* build: install Java 17 and update expected dependency output
* test(integration): disable Gradle dep analysis tests temporarily
* chore(deps): update cyclonedx-gradle to 1.7.4

---------

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants