Reorg #274
Merged
Reorg #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 15, 2021
Closed
| } | ||
| } | ||
| } | ||
|
|
| } | ||
| } | ||
|
|
||
| public void listenForOrderEventsNew() throws Exception { |
There was a problem hiding this comment.
could we call all these method changes "Queue" and "Topic" instead of "Old" and "New" to better describe?
There was a problem hiding this comment.
Good idea. I will make that change.
| @@ -0,0 +1,29 @@ | |||
| -- Copyright (c) 2021 Oracle and/or its affiliates. | |||
There was a problem hiding this comment.
could these file names be more descriptive? eg this file seems to grant privs and add subscriber but is named grabdish/config/db/2db-sa/apply/03-db1-aq.sql
There was a problem hiding this comment.
The names are designed to be processed automatically. The number, for example 03, defines the order of application. db1 means apply to db1, the aq refers to AQ settings. I will add a little more description to the name.
paulparkinson
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested and all is working except inventory-springboot. Need help to code for pub/sub. My plan is to check-in, update doc and then publish new label.