Added methods to set default namespace (onprem only) #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
cezarfx
previously requested changes
Jan 23, 2023
driver/src/main/java/oracle/nosql/driver/NoSQLHandleConfig.java
Outdated
Show resolved
Hide resolved
driver/src/main/java/oracle/nosql/driver/util/HttpConstants.java
Outdated
Show resolved
Hide resolved
gmfeinberg
reviewed
Jan 26, 2023
driver/src/main/java/oracle/nosql/driver/NoSQLHandleConfig.java
Outdated
Show resolved
Hide resolved
gmfeinberg
reviewed
Jan 26, 2023
driver/src/main/java/oracle/nosql/driver/NoSQLHandleConfig.java
Outdated
Show resolved
Hide resolved
gmfeinberg
reviewed
Jan 26, 2023
|
Shouldn't there be per-request methods as well, similar to compartment? |
Updated javadoc Changed header to "x-nosql-default-ns"
…feature/default_namespaces
cezarfx
reviewed
Jan 31, 2023
driver/src/main/java/oracle/nosql/driver/NoSQLHandleConfig.java
Outdated
Show resolved
Hide resolved
cezarfx
reviewed
Feb 7, 2023
driver/src/main/java/oracle/nosql/driver/NoSQLHandleConfig.java
Outdated
Show resolved
Hide resolved
cezarfx
dismissed
their stale review
Comment was on old revision of the file.
cezarfx
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods are hidden for now.
Requires onprem KV version 22.3, patch revision 24 or higher.