Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run Jacoco/Coveralls for forks #2079

Merged
merged 3 commits into from
Apr 23, 2018
Merged

Do not run Jacoco/Coveralls for forks #2079

merged 3 commits into from
Apr 23, 2018

Conversation

vladak
Copy link
Member

@vladak vladak commented Apr 23, 2018

Should still work for pull requests.

@coveralls
Copy link

coveralls commented Apr 23, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 2387

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 8 files lost coverage.
  • Overall coverage remained the same at 73.221%
Files with Coverage Reduction New Missed Lines %
src/org/opensolaris/opengrok/history/FileHistoryCache.java 1 73.52%
src/org/opensolaris/opengrok/history/SCCSRepository.java 1 78.91%
src/org/opensolaris/opengrok/history/GitRepository.java 2 62.04%
src/org/opensolaris/opengrok/analysis/AnalyzerGuru.java 2 85.27%
src/org/opensolaris/opengrok/history/HistoryGuru.java 2 73.75%
src/org/opensolaris/opengrok/history/RepositoryFactory.java 3 85.42%
src/org/opensolaris/opengrok/history/BitKeeperRepository.java 3 82.95%
src/org/opensolaris/opengrok/history/MercurialRepository.java 4 81.72%
Totals Coverage Status
Change from base Build 2386: 0.0%
Covered Lines: 30821
Relevant Lines: 42093
💛 - Coveralls

ahornace
ahornace approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@ahornace ahornace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine :) I tried disabling coveralls and updated one PR and also tried this branch on my fork.

@vladak vladak merged commit 912d897 into oracle:master Apr 23, 2018
@tarzanek tarzanek added this to the 1.1 milestone Apr 23, 2018
@tarzanek
Copy link
Contributor

lovely, works now!
purrfect! thank you @vladak ! :-D
( https://travis-ci.org/tarzanek/OpenGrok works! )

@vladak vladak deleted the jacoco_forks branch April 24, 2018 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahornace ahornace ahornace approved these changes

Assignees

@vladak vladak

Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@vladak @coveralls @tarzanek @ahornace