Search result background color for odd rows fix #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good enough to me. |
tarzanek
reviewed
Apr 26, 2018
| @@ -253,6 +247,20 @@ public static void prettyPrint(Writer out, SearchHelper sh, int start, | |||
| out.write("</tt></td></tr>\n"); | |||
| } | |||
| } | |||
| out.write("</tbody>"); | |||
There was a problem hiding this comment.
really?
(I am just confused it wasn't there before ... isn't it closed somewhere else? )
There was a problem hiding this comment.
I was surprised as well. It seems the browser adds it there by itself.
Simple test: (when I Inspect Element the <tbody> is there)
<!doctype html>
<html>
<head>
</head>
<body>
<table>
<tr><td>test1</td></tr>
<tr><td>test2</td></tr>
</table>
</body>
</html>
|
looks OK to me too, what will we do with coverage @vladak ? |
|
AFAIK this area of code is not covered at all so I am fine with integrating this as is. |
|
thank you, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2082
I was not able to resolve this by css :(
Thanks for review :)
For comparison: (almost the same part as described in issue)
