Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/more tests #2164

Merged
merged 6 commits into from
Jul 2, 2018
Merged

Feature/more tests #2164

merged 6 commits into from
Jul 2, 2018

Conversation

idodeclare
Copy link
Contributor

Hello,

Please consider for integration this patch that adds some test fixtures and also removes a small amount of unused code to help improve reported test coverage for some classes.

Thank you.

@coveralls
Copy link

coveralls commented Jun 16, 2018

Pull Request Test Coverage Report for Build 2575

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.9%) to 73.761%

Files with Coverage Reduction New Missed Lines %
src/org/opensolaris/opengrok/history/SCCSRepository.java 1 79.27%
src/org/opensolaris/opengrok/history/HistoryGuru.java 2 75.4%
src/org/opensolaris/opengrok/history/RepositoryFactory.java 3 86.27%
src/org/opensolaris/opengrok/history/BitKeeperRepository.java 3 79.72%
src/org/opensolaris/opengrok/configuration/RuntimeEnvironment.java 5 71.51%
Totals Coverage Status
Change from base Build 2572: 0.9%
Covered Lines: 31577
Relevant Lines: 42810

💛 - Coveralls

@tarzanek tarzanek self-assigned this Jun 27, 2018
@tarzanek tarzanek added this to the 1.1 milestone Jun 27, 2018
@tarzanek
Copy link
Contributor

thank you, this looks good, merging
(and was quick to read :) ... I'll make sure I'll come back to other PRs soon)

@tarzanek
Copy link
Contributor

I am wondering if you can update the branch to be on top of master, or if I can just do rebase and merge ...

@idodeclare
Copy link
Contributor Author

@tarzanek yes I've learned one can now happily force-push branches (which I seem to remember at one time would ruin GitHub PRs), but the GitHub rebase-and-merge is the equivalent.

@tarzanek
Copy link
Contributor

tarzanek commented Jul 2, 2018

ok, let's try rebase and merge then, thank you Chris

@tarzanek tarzanek merged commit 1ae5498 into oracle:master Jul 2, 2018
@idodeclare idodeclare deleted the feature/more_tests branch July 3, 2018 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants