-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/more tests #2164
Feature/more tests #2164
Conversation
Pull Request Test Coverage Report for Build 2575
💛 - Coveralls |
thank you, this looks good, merging |
I am wondering if you can update the branch to be on top of master, or if I can just do rebase and merge ... |
@tarzanek yes I've learned one can now happily force-push branches (which I seem to remember at one time would ruin GitHub PRs), but the GitHub rebase-and-merge is the equivalent. |
ok, let's try rebase and merge then, thank you Chris |
Hello,
Please consider for integration this patch that adds some test fixtures and also removes a small amount of unused code to help improve reported test coverage for some classes.
Thank you.