Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename ldap -> ldapProvider #2165

Merged
merged 1 commit into from
Jun 19, 2018
Merged

rename ldap -> ldapProvider #2165

merged 1 commit into from
Jun 19, 2018

Conversation

vladak
Copy link
Member

@vladak vladak commented Jun 19, 2018

simple rename for better code readability

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2577

  • 3 of 7 (42.86%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.005%) to 72.834%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/src/opengrok/auth/plugin/AbstractLdapPlugin.java 3 7 42.86%
Files with Coverage Reduction New Missed Lines %
src/org/opensolaris/opengrok/history/SCCSRepository.java 1 78.05%
src/org/opensolaris/opengrok/history/HistoryGuru.java 2 74.87%
src/org/opensolaris/opengrok/history/RepositoryFactory.java 3 80.39%
src/org/opensolaris/opengrok/history/BitKeeperRepository.java 3 77.62%
src/org/opensolaris/opengrok/configuration/RuntimeEnvironment.java 3 71.51%
Totals Coverage Status
Change from base Build 2576: -0.005%
Covered Lines: 31186
Relevant Lines: 42818
💛 - Coveralls

@vladak vladak merged commit 12e6cf0 into oracle:master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulinkry tulinkry tulinkry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladak @coveralls @tulinkry