Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indexer: add java options to indexer #4589

Merged
merged 14 commits into from
Sep 11, 2024
Merged

indexer: add java options to indexer #4589

merged 14 commits into from
Sep 11, 2024
+33 −3

Conversation

hitmoon
Copy link
Contributor

@hitmoon hitmoon commented Jun 14, 2024

add INDEXER_JAVA_OPTS environment varibale
pass java_opts to Indexer to tune jvm options

This feature is useful for docker users

@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jun 14, 2024
@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jun 14, 2024
@vladak vladak self-requested a review June 24, 2024 13:21
vladak
vladak requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@vladak vladak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be documented in docker/README.md.

@vladak
Copy link
Member

vladak commented Jun 24, 2024

Also, black needs to be applied to start.py.

@hitmoon @vladak
indexer: add java options to indexer
f685b95 
add INDEXER_JAVA_OPTS environment varibale
pass java_opts to Indexer to tune jvm options

This feature is useful for docker users

Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
vladak
vladak reviewed Sep 11, 2024
View reviewed changes
docker/start.py Outdated Show resolved Hide resolved
vladak
vladak reviewed Sep 11, 2024
View reviewed changes
docker/start.py Outdated Show resolved Hide resolved
vladak
vladak reviewed Sep 11, 2024
View reviewed changes
docker/start.py Outdated Show resolved Hide resolved
vladak
vladak reviewed Sep 11, 2024
View reviewed changes
docker/start.py Outdated Show resolved Hide resolved
vladak
vladak reviewed Sep 11, 2024
View reviewed changes
docker/start.py Outdated Show resolved Hide resolved
vladak
vladak reviewed Sep 11, 2024
View reviewed changes
docker/start.py Outdated Show resolved Hide resolved
vladak
vladak reviewed Sep 11, 2024
View reviewed changes
docker/start.py Outdated Show resolved Hide resolved
vladak
vladak reviewed Sep 11, 2024
View reviewed changes
docker/start.py Outdated Show resolved Hide resolved
vladak
vladak reviewed Sep 11, 2024
View reviewed changes
docker/start.py Outdated Show resolved Hide resolved
vladak
vladak reviewed Sep 11, 2024
View reviewed changes
docker/start.py Outdated Show resolved Hide resolved
vladak
vladak reviewed Sep 11, 2024
View reviewed changes
docker/start.py Outdated Show resolved Hide resolved
vladak
vladak approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@vladak vladak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the black formatting issues myself

@vladak vladak merged commit bd4dda7 into oracle:master Sep 11, 2024
9 checks passed
@vladak vladak added the docker label Sep 11, 2024
@vladak vladak mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladak vladak vladak approved these changes

Assignees
No one assigned
Labels
docker OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hitmoon @vladak