-
Notifications
You must be signed in to change notification settings - Fork 62
Closed
Description
Defining the same database (database connection string = same user,pwd and service name) in the config file for the observer is not handle when the name tags for the db are different.
Steps to Reproduce:
- Create databaseobserver_neg.yaml with 3 databases and a config file
- In the config file use different names for the databases definitions but specify the username, password and url for database 1 in all 3 databases
- Create config file configMap
- Apply databaseobserver_neg.yaml
- Monitor logs of the observer pod
Suggested Approach: add a WARN log. We can add a validation step to the configuration loader, which in general is a good idea, and this would be part of it
Example:
WARN duplicated database url: databases 'x', 'y', and 'z' reference the same database URL.
In the config file..
config-neg.yaml
databases:
adw:
username: ${ADW_USER}
password: ${ADW_PWD}
url: k8sadw_high
atp:
username: ${ADW_USER}
password: ${ADW_PWD}
url: k8sadw_high
adw2:
username: ${ADW_USER}
password: ${ADW_PWD}
url: k8sadw_high
Metadata
Metadata
Assignees
Labels
No labels