Package updates #187
Merged
Package updates #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
andytael
reviewed
Feb 28, 2025
| - Fix malloc error (#177) | ||
| - Fix Multiple custom metrics files overwrite one another (#179) | ||
| - Replace go-kit/log with log/slog, due to upstream changes in prometheus/common | ||
| - Add support for additional admin roles, exapnding list of options for `DB_ROILE` to `SYSDBA`, `SYSOPER`, `SYSBACKUP`, `SYSDG`, `SYSKM`, `SYSRAC` and `SYSASM` (#180) |
andytael
reviewed
Feb 28, 2025
collector/collector.go
Outdated
| return | ||
| } | ||
|
|
||
| if len(metric.MetricsDesc) == 0 { | ||
| errChan <- errors.New("metricsdesc not found") | ||
| level.Error(e.logger).Log("msg", "Error scraping for query"+fmt.Sprint(metric.Request)+". Did you forget to define metricsdesc in your toml file?") | ||
| e.logger.Error("Error scraping for query" + fmt.Sprint(metric.Request) + ". Did you forget to define metricsdesc in your toml file?") |
There was a problem hiding this comment.
Looks a double space between metricsdesc and in
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
markxnelson
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.