Skip to content

Add configuration control for /tmp file system #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2022
Merged

Add configuration control for /tmp file system #67

merged 1 commit into from
Nov 18, 2022

Conversation

vadim-or
Copy link
Member

No description provided.

AmedeeBulle
AmedeeBulle reviewed Jun 27, 2022
View reviewed changes
Copy link
Member

@AmedeeBulle AmedeeBulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just run the following (or something similar) from the image-scripts instead of adding a section in the ks file?

sed -e 's!\(services .*--enabled="[^"]*\)"!\1,tmp.mount"!' "${ks_file}"

@vadim-or vadim-or force-pushed the vadim-or/add-configuration-control-for-tmp-filesystem branch from 91cc7b1 to a92d017 Compare June 29, 2022 16:41
@vadim-or
Copy link
Member Author

Thank you for the great suggestion!

@AmedeeBulle AmedeeBulle marked this pull request as draft June 30, 2022 07:59
@vadim-or vadim-or force-pushed the vadim-or/add-configuration-control-for-tmp-filesystem branch from a92d017 to 900b6e4 Compare November 3, 2022 16:50
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 3, 2022
AmedeeBulle
AmedeeBulle reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@AmedeeBulle AmedeeBulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- apologies for the delay

@AmedeeBulle AmedeeBulle marked this pull request as ready for review November 18, 2022 14:51
@AmedeeBulle AmedeeBulle merged commit fa18118 into oracle:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmedeeBulle AmedeeBulle AmedeeBulle left review comments

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vadim-or @AmedeeBulle