Support tagging resources in single node, admin and cluster offer #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increase pom upgrade Microsoft.Resources/deployments API version add toolTip for tag control. fix artifact version
oracle-contributor-agreement
bot
added
the
OCA Verified
modified: resources/doc/guidance-for-tagging-resource.md Signed-off-by: Ed Burns <edburns@microsoft.com>
modified: resources/doc/guidance-for-tagging-resource.md Signed-off-by: Ed Burns <edburns@microsoft.com>
… resource type identifiers are filtered. modified: resources/azure-common.properties Signed-off-by: Ed Burns <edburns@microsoft.com>
edburns
reviewed
Sep 17, 2024
| identifier.vaults=Microsoft.KeyVault/vaults | ||
| identifier.virtualNetworks=Microsoft.Network/virtualNetworks | ||
| identifier.virtualMachines=Microsoft.Compute/virtualMachines | ||
| identifier.virtualMachinesExtensions=Virtual machine extension |
There was a problem hiding this comment.
I want to know why this one is a human readable value "Virtual machine extension" while the others are resource type identifiers.
There was a problem hiding this comment.
Hello @edburns path of the two resources are not recognized by the Tag control, and I want to allow the customer to provide specified tag for them. The VM deployment from portal has similar experience.
There was a problem hiding this comment.
So is this a bug in Azure, @galiacheng ?
edburns
reviewed
Sep 17, 2024
| identifier.virtualMachinesExtensions=Virtual machine extension | ||
| identifier.deploymentScripts=Microsoft.Resources/deploymentScripts | ||
| identifier.userAssignedIdentities=Microsoft.ManagedIdentity/userAssignedIdentities | ||
| identifier.resourcesDeployment=Microsoft resources deployment |
There was a problem hiding this comment.
I want to know why this one is a human readable value "Microsoft resources deployment" while the others are resource type identifiers.
There was a problem hiding this comment.
See #327 (comment)
modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/mainTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/mainTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls/src/main/arm/mainTemplate.json Signed-off-by: Ed Burns <edburns@microsoft.com>
…lace. modified: resources/azure-common.properties modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/mainTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/_dbTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/_dnszones/_createDNSZonesTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/_dnszones/_uamiAndRoleAssignment.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/_dnszones/_updateDNSZonesTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/_installJdbcLibsTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/_keyVaultNestedTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/_pswlessDbTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/aadNestedTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/adminTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/adminTemplateForCustomSSL.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/dbTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/dnszonesTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/elkNestedTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/mainTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/_dbTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/_dnszones/_createDNSZonesTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/_dnszones/_uamiAndRoleAssignment.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/_dnszones/_updateDNSZonesTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/_installJdbcLibsTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/_keyvault/_keyvaultWithExistingCertTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/_keyvault/_keyvaultWithNewCertTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/_keyvaultAdapterTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/_keyvaultAppGatewayConnectorTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/_keyvaultSSLConfigTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/_pswlessDbTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/aadNestedTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/appGatewayNestedTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/clusterCustomSSLTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/clusterTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/coherenceTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/dbTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/dnszonesTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls-cluster/arm-oraclelinux-wls-cluster/src/main/arm/nestedtemplates/elkNestedTemplate.json modified: weblogic-azure-vm/arm-oraclelinux-wls/src/main/arm/mainTemplate.json Signed-off-by: Ed Burns <edburns@microsoft.com>
edburns
suggested changes
Sep 17, 2024
There was a problem hiding this comment.
See comments like, "I want to know why this one is a human readable
value "..." while the others are resource type identifiers.". If these
two human readable values can be replaced by their corresponding
resource type identifier values, please do that. Otherwise, I suggest
the property name reflect how they differ from the rest of the similar
property names. For example, perhaps they should be
label.virtualMachinesExtensions or
identifier.label_virtualMachinesExtensions.
I am very confident you have a reason for this, but I seek to
understand it.
Good catch, please see #327 (comment). |
rjeberhard
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the GitHub workflows, version upgrades in the
pom.xmlfile, and enhancements for resource tagging in Azure templates. The most important changes include updating thedownload-artifactaction version, upgrading WebLogic versions, adding resource identifiers for Azure tagging, and providing guidance on applying tags in solution templates.Workflow and Action Updates:
download-artifactaction fromv1tov4in multiple GitHub workflow files to ensure compatibility and leverage new features. (.github/workflows/testWlsAksWithDependencyCreation.yml,.github/workflows/testWlsAksWithoutDependencyCreation.yml,.github/workflows/testWlsVmAdmin.yml,.github/workflows/testWlsVmCluster.yml,.github/workflows/testWlsVmDynamicCluster.yml) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Version Upgrades:
pom.xmlfile to the latest releases for improved performance and security. (pom.xml)Resource Tagging Enhancements:
azure-common.propertiesto support filtering tags for various Azure resources. (resources/azure-common.properties)createUiDefinition.jsonfor tagging resources and updated the main template to handle these tags. (weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/createUiDefinition.json,weblogic-azure-vm/arm-oraclelinux-wls-admin/src/main/arm/mainTemplate.json) [1] [2] [3] [4] [5]Documentation:
resources/doc/guidance-for-tagging-resource.md)