-
Notifications
You must be signed in to change notification settings - Fork 16
Support re-deployment in the same resource group and remove external key vault integration #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
4eda65d
unique name for public ip.
galiacheng 5abd8fc
use global resource name sufix.
galiacheng 414f79b
remove var name_appGateway as there is a param for it.
galiacheng a1e54cb
define _globalResourceNameSufix: _globalResourceNameSufix in the scal…
galiacheng 636c55e
mitigate Bicep warning.
galiacheng 822f165
add location input parameter to workflow for resource creation
galiacheng b3c355d
use java 11 to build cargotracker.
galiacheng 074e8c0
fix syntax issue
galiacheng c4f6ef9
add sufix to the uami name.
galiacheng ba1458d
ensure all the depoyment script deployments have unique name.
galiacheng 52b9d87
ensure key vault permission model is vault access policy.
galiacheng 444027b
enable global uami to access existing key vault.
galiacheng 054f171
create a seperate module to update access policy of key vault.
galiacheng d84d942
set enableRbacAuthorization with false.
galiacheng 3b718e1
specify location.
galiacheng ccd9433
fix build error
galiacheng e98a272
Error BCP035: The specified "object" declaration is missing the follo…
galiacheng 6d1c1f2
set vault sku
galiacheng 896ee0d
rename key vault resource
galiacheng ad5f038
remove key vault from ui.
galiacheng 1049656
remove key vault
galiacheng 8982ab4
remove key vault validation in fail fast stage.
galiacheng a641652
update key vault API version
galiacheng 3075c59
Fix "An invalid value was provided for 'accessPolicies[0].Permissions…
galiacheng 73b3847
Set key vault certificate permission.
galiacheng 07b3f68
upgrade jdk version
galiacheng fcc8e84
Code clean up.
galiacheng a69ffe8
No key vault info when the App Gateway certificate is uploaded.
galiacheng 42f073f
validate existing aks networking configurations.
galiacheng 51c07fe
upgrade aks to 1.30.7.
galiacheng dc5a579
On branch wls-aks-redeploy Update names to match what they are naming.
edburns 5832f05
On branch wls-aks-redeploy Fix typo sufix -> suffix
edburns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much better to not hard code this!