-
Notifications
You must be signed in to change notification settings - Fork 16
Changes related to default outbound access for admin offer #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0b4f13a
Changes related to default outbound access for admin offer
ed97c55
Updated the changes as per review comments
f7a2a90
On branch edburns/o-717-default-outbound-admin-vm
edburns b7f909f
Merge pull request #1 from azure-javaee/edburns/o-717-default-outboun…
sanjaymantoor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107 changes: 107 additions & 0 deletions
107
...ure-vm/arm-oraclelinux-wls-admin/src/main/arm/nestedtemplates/postDeploymentTemplate.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2018-05-01/subscriptionDeploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "parameters": { | ||
| "location": { | ||
| "type": "string", | ||
| "metadata": { | ||
| "description": "Location for all resources." | ||
| } | ||
| }, | ||
| "_globalResourceNameSuffix": { | ||
| "type": "string", | ||
| "metadata": { | ||
| "description": "A unique suffix that was specified during the deployment of the solution template." | ||
| } | ||
| }, | ||
| "tagsByResource": { | ||
| "type": "object", | ||
| "defaultValue": {}, | ||
| "metadata": { | ||
| "description": "${label.tagsLabel}" | ||
| } | ||
| }, | ||
| "const_guidTag" :{ | ||
| "type": "string", | ||
| "metadata": { | ||
| "description": "A unique tag for resources." | ||
| } | ||
| }, | ||
| "_artifactsLocation": { | ||
| "type": "string", | ||
| "metadata": { | ||
| "description": "The base URI where artifacts required by this template are located. When the template is deployed using the accompanying scripts, a private location in the subscription will be used and this value will be automatically generated." | ||
| } | ||
| }, | ||
| "_artifactsLocationAdminTemplate": { | ||
| "defaultValue": "[if(contains(parameters('_artifactsLocation'), 'githubusercontent'), parameters('_artifactsLocation'), deployment().properties.templateLink.uri)]", | ||
| "type": "string", | ||
| "metadata": { | ||
| "description": "If we are deploying from the command line, use the passed in _artifactsLocation, otherwise use the default." | ||
| } | ||
| }, | ||
| "_artifactsLocationSasToken": { | ||
| "type": "securestring", | ||
| "metadata": { | ||
| "description": "The sasToken required to access _artifactsLocation. When the template is deployed using the accompanying scripts, a sasToken will be automatically generated. Use the defaultValue if the staging location is not secured." | ||
| } | ||
| }, | ||
| "userAssignedIdentityResourceId":{ | ||
| "type": "string", | ||
| "metadata": { | ||
| "Description": "UserAssigned Identity" | ||
| } | ||
| }, | ||
| "utcValue": { | ||
| "type": "string", | ||
| "defaultValue": "[utcNow()]" | ||
| } | ||
| }, | ||
| "variables": { | ||
| "name_postDeploymentscriptFile": "postDeploymentScript.sh" | ||
| }, | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Resources/deploymentScripts", | ||
| "apiVersion": "${azure.apiVersionForDeploymentScript}", | ||
| "tags": "[parameters('tagsByResource')['${identifier.deploymentScripts}']]", | ||
| "name": "[concat('postdeployscript-', parameters('_globalResourceNameSuffix'))]", | ||
| "kind": "AzureCLI", | ||
| "location": "[parameters('location')]", | ||
| "identity": { | ||
| "type": "UserAssigned", | ||
| "userAssignedIdentities": { | ||
| "[parameters('userAssignedIdentityResourceId')]": {} | ||
| } | ||
| }, | ||
| "properties": { | ||
| "forceUpdateTag": "[parameters('utcValue')]", | ||
| "azCliVersion": "2.9.1", | ||
| "timeout": "PT30M", | ||
| "cleanupPreference": "OnSuccess", | ||
| "retentionInterval": "P1D", | ||
| "primaryScriptUri": "[uri(parameters('_artifactsLocationAdminTemplate'), concat('../scripts/', variables('name_postDeploymentscriptFile'), parameters('_artifactsLocationSasToken')))]", | ||
| "environmentVariables": [ | ||
| { | ||
| "name": "MANAGED_IDENTITY_ID", | ||
| "value": "[parameters('userAssignedIdentityResourceId')]" | ||
| }, | ||
| { | ||
| "name": "RESOURCE_GROUP_NAME", | ||
| "value": "[resourceGroup().name]" | ||
| }, | ||
| { | ||
| "name": "GUID_TAG", | ||
| "value": "[parameters('const_guidTag')]" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ], | ||
| "outputs": { | ||
| "userAssignedIdentityResource": { | ||
| "type": "string", | ||
| "value": "[parameters('userAssignedIdentityResourceId')]" | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You use the same name for ip address for both
newandexistingvNet:New
Existing
Pls merge them into one resource with different values for properties impacted by value
parameters('virtualNetworkNewOrExisting').