Updated WLST data type compatibility check method to see "class java.… #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lang.Log" and "<type 'javainstance'>" as being compatible with WLST long
…riable_file_name was passed in
…nly'" reference variable, during the entire validation process
ddsharpe
requested changes
May 24, 2018
| @@ -108,9 +109,11 @@ def validate_in_standalone_mode(self, model_dict, variables_file_name=None, arch | |||
| """ | |||
| _method_name = 'validate_in_standalone_mode' | |||
|
|
|||
| cloned_model_dict = copy.deepcopy(model_dict) | |||
There was a problem hiding this comment.
Please add a comment here to describe why its necessary to do a deep copy so someone doesn't accidentally change it back.
ddsharpe
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #107, #108 and #112