Documentation changes for target type changes #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakillen
added
the
hold for next release
ddsharpe
reviewed
Feb 14, 2022
|
|
||
| #### `additional_secrets` | ||
|
|
||
| This field specifies a comma-separated list of secret types that are to be included in the Kubernetes resource file and the create secrets script. There is one secret type available: |
There was a problem hiding this comment.
Is it "...list of secret types" or should it be "..list of secrets"?
Is runtime-encryption-secret a type or a secret?
There was a problem hiding this comment.
It's a type (key) - for the only existing case, we match the key and include a specific attribute / value in the resource file, and add a secret name that's not an exact match. Users can't put a random secret in here and expect to see it in the resource file or create secrets script.
robertpatrick
approved these changes
Feb 17, 2022
robertpatrick
removed
the
hold for next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
use_persistent_volumefor target configuration file.Changed location of resource file templates.
Use "Kubernetes resource file" for Verrazzano and general case.