Skip to content

Issue #275 - Join discovered lists using comma delimiter only; split … #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2019

Conversation

rakillen
Copy link
Member

@rakillen rakillen commented Mar 6, 2019

Join discovered lists using comma delimiter only; split classpath on comma when adding to archive.
Fixes #275

…classpath on comma when adding to archive
@surskitt
Copy link

surskitt commented Mar 7, 2019

I've checked out the pull request and it seems like the produced model, with comma separated classpath entries fails validation during createDomain

####<07-Mar-2019 15:49:03> <SEVERE> <ValidationResults> <log_results> <WLSDPLY-05024> <Attribute ClassPath in model location topology:/Server/mydomain_admin/ServerStart/SERVER_START-0 references entry wlsdeploy/classpathLibraries/javax.persistence_1.1.0.0_2-0.jar,wlsdeploy/classpathLibraries/com.oracle.jpa2support_1.0.0.0_2-1.jar,wlsdeploy/classpathLibraries/weblogic_patch.jar,wlsdeploy/classpathLibraries/weblogic.jar that is not found in the archive file /home/bea/mydomain_archive.zip>

It still seems to be searching for the full comma separated string as a filename entry in the zip.

@rakillen
Copy link
Member Author

rakillen commented Mar 8, 2019

Fixed logic for validation of library paths. Isolated the comma-delimiter discovery change to Server/ServerStart/ClassPath. Fixes #275

@ddsharpe ddsharpe merged commit 5e65256 into master Mar 8, 2019
@ddsharpe ddsharpe deleted the issue-275-splitting-classpath branch March 8, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants