run decrypt for admin credentials before creating boot.properites as … #407
Conversation
…they may have encrypted.
There was a problem hiding this comment.
This change looks fine. But, the previous boot.properties change still needs to be addressed. Creating boot.properties needs to be optional for the user. The previous change made creation of boot.properties all the time. They should be optional for the on-prem customer that does not want boot.properties on their file system.
…mic servers and may be a risk for production system
| @@ -1121,6 +1120,9 @@ def __create_boot_dot_properties(self): | |||
|
|
|||
| for server in servers: | |||
| properties = Properties() | |||
|
|
|||
| admin_username = self.aliases.decrypt_password(admin_username) | |||
There was a problem hiding this comment.
Why do you need to decrypt it each time there is a server (for every server)? Shouldn't this decrypt step be done near line 1110 (outside of the for-loop)?
There was a problem hiding this comment.
Yea, I know about that. Both decrypt and encrypt of credentials can be outside the loop, I also change to create boot.properties when it is not in production mode
decrypt admin credentials from model before creating boot.properties