Skip to content

Developer guide #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Aug 29, 2019
Merged

Developer guide #410

merged 39 commits into from
Aug 29, 2019

Conversation

ddsharpe
Copy link
Member

@ddsharpe ddsharpe commented Jul 9, 2019

No description provided.

Copy link
Contributor

@CarolynRountree CarolynRountree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline.

@ddsharpe ddsharpe changed the title WIP: Developer guide *DO NOT MERGE WITHOUT 100% APPROVAL* Developer guide Aug 20, 2019
rakillen
rakillen previously approved these changes Aug 20, 2019
Copy link
Contributor

@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor stuff

rakillen
rakillen previously approved these changes Aug 21, 2019
Copy link
Contributor

@CarolynRountree CarolynRountree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only comment I have is to provide a better description of what the functionality section contains. I did not understand until you told me. And then it made sense. If you could convey it bit more clearly in the introduction line (or 2)

@ddsharpe ddsharpe merged commit acd9e5c into master Aug 29, 2019
@ddsharpe ddsharpe deleted the developer-guide branch August 29, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants